[Softdevice-devel] OSD layer not always fully cleared on mgatv

[Stefan Lucke]

On Montag 25 September 2006 09:37, Marko Mäkelä wrote:
> On Sun, Sep 24, 2006 at 11:23:44PM +0200, Stefan Lucke wrote:
> > > > Patch dfb-blbar-clear-03.patch includes this and osdMutex removal
> > > > from video-dfb.c . Did only a compile check with this one.
> > > 
> > > I tested this one first.  It removed the fading effect, but unfortunately
> > > it also caused OSD updates to take much longer or to be lost.  When I
> > > pressed the Down button for a second in a short Recordings menu that fits
> > > entirely on screen, the selection jumped around in a bit chaotic way.
> > > I'm just guessing, but could it be a locking granularity issue?
> > 
> > Was that during live-tv or during a paused playback of a recording?
> > Could be an issue with triplebuffering too.
> 
> It was during live-tv.  Would you like me to repeat this and send you the
> log messages?  Should I enable some extra diagnostics?

I think I have to test this with tv-out too as I didn't get the effects
you described with vga out.

You can however do the following (if you like):
- If you've still enabled youre usleeps, disable them.
- dirtyLines in GetLockOsdSurface() should be cleared by:
  memset(dirtyLines,false,sizeof(bool)*Yres);
  as sizeof(dirtyLines) is 4 :-) .
- I guess method ShowOSD() can be dropped. Dropping should be ok now
  for live-tv, but needs some extra handling when paused. In that case
  handling from video:Action() should be like 
  current_osdMode == OSDMODE_SOFTWARE.

-- 
Stefan Lucke