[Haiku-commits] r29727 - haiku/trunk/src/kits/interface

[Alexandre Deckner]

Alexandre Deckner wrote:
> Stephan Assmus wrote:
>   
>> Hi,
>>
>> On 2009-03-26 at 13:09:29 [+0100], aldeck at BerliOS 
>> <aldeck at mail.berlios.de> @@ -118,9 +118,12 @@
>>   
>>     
>>>      BMessage popupMsg;
>>>      
>>>      if (fPopUp) {
>>> -        ret = fPopUp->Archive(&popupMsg, deep);
>>> -        if (ret == B_OK)
>>> -            ret = data->AddMessage("_popup", &popupMsg);
>>> +        if (fPopUp->Window()->Lock()) {
>>> +            ret = fPopUp->Archive(&popupMsg, deep);
>>> +            if (ret == B_OK)
>>> +                ret = data->AddMessage("_popup", &popupMsg);
>>> +            fPopUp->Window()->Unlock();
>>> +        }
>>>     
>>>       
>> Nice! The above could be improved by setting "ret" to B_ERROR if the window 
>> can not be locked.
>>     
> Correct! (T.I Speak & Spell voice :D)
In fact, it's not working as expected :) This can happen under normal 
conditions. Trying to replicate a view from the desktop to Shelftest 
fails sometimes with this. Besides i just rechecked the bebook and  the 
menu should only be archived if it's a custom provided menu. Will rework 
that part asap.

Alex