[Haiku-commits] r31243 - in haiku/trunk/src: add-ons/kernel/debugger/demangle apps/debugger/demangler

Axel Dörfler axeld at pinc-software.de
Fri Jun 26 09:35:06 CEST 2009


phoudoin at mail.berlios.de wrote:
> I hope I didn't break coding guideline doing so.

Only a few:

> +++ haiku/trunk/src/add-ons/kernel/debugger/demangle/demangle.h	
> 2009-06-25 22:49:07 UTC (rev 31243)
> @@ -7,7 +7,15 @@
>  
>  #include <SupportDefs.h>
>  
> +const char*
> +demangle_symbol(const char* mangledName, char* buffer, size_t 
> bufferSize,
> +	bool* _isObjectMethod);

Two blank lines between prototype and header, for prototypes, the 
return type and rest is on one line.

> +++ haiku/trunk/src/apps/debugger/demangler/Demangler.cpp	2009-06-25 
> 22:49:07 UTC (rev 31243)
> @@ -3,6 +3,8 @@
>   * Distributed under the terms of the MIT License.
>   */
>  
> +#include <TypeConstants.h>
> +
>  #include "Demangler.h"

While we (unfortunately) agreed on going from generic headers to 
specific headers (ie. first POSIX, then Be API, then private stuff, 
then local stuff), the header counterpart of a source file should 
always come first, to see whether or not it's self-contained.

[...]
> +	
> +	demangled = demangle_symbol(mangledName.String(), buffer,
> +			sizeof(buffer), NULL);
> +	if (demangled == NULL)

Only a single tab to indent the second line here.

The rest looks good, HTH :-)

Bye,
   Axel.




More information about the Haiku-commits mailing list