[Haiku-commits] r31212 - in buildtools/branches/gcc-config-wchar: gcc2 gcc4

[Joseph Prostko]

On Tue, Jun 23, 2009 at 11:52 AM, zooey at BerliOS<zooey at mail.berlios.de> wrote:
> Author: zooey
> Date: 2009-06-23 17:52:32 +0200 (Tue, 23 Jun 2009)
> New Revision: 31212
> ViewCVS: http://svn.berlios.de/viewcvs/haiku?rev=31212&view=rev
>
> Modified:
>   buildtools/branches/gcc-config-wchar/gcc2/haiku.h
>   buildtools/branches/gcc-config-wchar/gcc4/haiku.h
> Log:
> * changed definitions of wchar_t from unsigned short to int, since that makes
>  much more sense (being able to store a unicode character point in a wchar_t)
> * this fixes several problems in wchar-related functions, as our implementation
>  relies on wchar_t being 32 bits wide

I see that this is the gcc/config/i386/haiku.h header.

For the long haul, would it be best to make these changes (and other
redundancies) to the haiku.h that resides in gcc/config, seeing as
every haiku architecture target seems to share the same defines in
this regard?  I know x86 is the main focus for now, but I think it'd
make more sense to utilize the config/haiku.h, and then override when
necessary in haiku's architecture-specific headers.

- joe