[Haiku-commits] r30975 - in haiku/trunk: headers/private/kernel src/system/kernel/fs src/system/kernel/vm

[Ingo Weinhold]

-------- Original-Nachricht --------
> Datum: Thu, 18 Jun 2009 09:08:31 -0500
> Von: Rene Gollent <anevilyak at gmail.com>

> On Fri, Jun 5, 2009 at 10:52 AM, axeld at BerliOS<axeld at mail.berlios.de>
> wrote:
> >                TRACE(("trying to mount boot partition: %s\n",
> path.Path()));
> >                gBootDevice = _kern_mount("/boot", path.Path(),
> fsName, 0, NULL, 0);
> > -               if (gBootDevice >= B_OK)
> > +               if (gBootDevice >= B_OK) {
> > +                       gReadOnlyBootDevice = true;
> >                        break;
> > +               }
> >        }
> 
> Isn't this marking the boot device as read only in all cases, and thus
> preventing a swap file from ever being created?

It doesn't seem to be reset anywhere, so I'd say that's indeed the problem.

CU, Ingo

PS: A stylistic remark: The popular ">= B_OK" comparison is not really correct, since _kern_mount() (and many other functions) doesn't ever return B_OK. It either returns a value >= 0 on success or a negative error code on failure.