[Haiku-commits] r30894 - haiku/trunk/src/kits/tracker

Axel Dörfler axeld at pinc-software.de
Fri Jun 5 10:29:04 CEST 2009


Philippe Saint-Pierre <stpere at gmail.com> wrote:
> 2009/5/28 Axel Dörfler <axeld at pinc-software.de>
> > > This implement the suggestion in ticket #2868.
> > Not sure this is a good idea - this can get pretty expensive, and 
> > also
> > slow, since each change is followed by a complete rescan. I don't 
> > think
> > we should keep it that way.
> Are you against the whole idea or against my implementation?  
> (against might
> be a bit hard..)
> 
> If it's the former, I will revert the change completely,
> 
> if it's the later, I have a few optimisations in mind, like actually 
> using
> the information returned by the monitoring, rather than scanning the 
> whole
> thing again.

There are a few things I don't like, most importantly, it's the delay 
until the window opens. This even happens when the size is not actually 
computed, btw (like for the "Home" link on your desktop).
Since it currently costs that many resources with large folders (like, 
usually, your home folder), I'm not sure this is a good feature to have 
in general. The complete rescan on changes is just the tip of the 
iceberg.

Bye,
   Axel.




More information about the Haiku-commits mailing list