[Haiku-commits] r27691 - haiku/trunk/src/kits/interface

[Urias McCullough]

2008/9/22  <mmlr at mail.berlios.de>:
> Author: mmlr
> Date: 2008-09-22 19:49:33 +0200 (Mon, 22 Sep 2008)
> New Revision: 27691
> ViewCVS: http://svn.berlios.de/viewcvs/haiku?rev=27691&view=rev
>
> Modified:
>   haiku/trunk/src/kits/interface/Bitmap.cpp
> Log:
> Remove check for a supplied bytesPerRow < 0. Negative values are valid and
> indicate that a default bytes per row for a certain color space and width
> should be used (B_ANY_BYTES_PER_ROW). Fixes CID 55.
>
>
> Modified: haiku/trunk/src/kits/interface/Bitmap.cpp
> ===================================================================
> --- haiku/trunk/src/kits/interface/Bitmap.cpp   2008-09-22 15:36:46 UTC (rev 27690)
> +++ haiku/trunk/src/kits/interface/Bitmap.cpp   2008-09-22 17:49:33 UTC (rev 27691)
> @@ -666,7 +666,7 @@
>        if (InitCheck() != B_OK)
>                return B_NO_INIT;
>
> -       if (!data || length < 0 || bpr < 0 || width < 0 || height < 0)
> +       if (!data || length < 0 || width < 0 || height < 0)
>                return B_BAD_VALUE;
>
>        if (bpr < 0)

Perhaps also deserves a modification to the comment above?

  		- \c B_OK: Everything went fine.
  		- \c B_BAD_VALUE: \c NULL \a data, invalid \a bpr, unsupported

What's an invalid bpr?