[Haiku-commits] r27420 - haiku/trunk/src/system/kernel/posix

[Salvatore Benedetto]

2008/9/11 Axel Dörfler <axeld at pinc-software.de>:
> sbenedetto at BerliOS <sbenedetto at mail.berlios.de> wrote:
>>  private:
>> +     int                                                     fID;                                    // semaphore
>> set id
>>       bool                                            fInitOK;
>> -     int                                                     fID;                                    // semaphore
>> set id
>>       time_t                                          fLastSemctlTime;                // sem_ctime
>>       time_t                                          fLastSemopTime;                 // sem_otime
>> +     mutex                                           fLock;                                  // private lock
>>       ushort                                          fNumberOfSemaphores;    // sem_nsems
>>       struct ipc_perm                         fPermissions;                   // sem_perm
>> +     XsiSemaphore                            *fSemaphores;                   // array of
>> semaphores
>>       uint32                                          fSequenceNumber;                // used as a
>> second id
>> -     XsiSemaphore                            *fSemaphores;                   // array of
>> semaphores
>>       UndoList                                        fUndoList;                              // undo list
>> requests
>> -     mutex                                           fLock;                                  // private lock
>
> Alphabetical ordering doesn't really make sense, though. For example,
> it would be better to move the ushort to the bool value, so that you
> only lose a single padding byte, not 5.

I did not take that in consideration.

Regards,
-- 
Salvatore Benedetto (a.k.a. emitrax)
Student of Computer Engineer
University of Pisa
www.haiku-os.it