[Haiku-commits] r28256 - haiku/trunk/src/add-ons/print/drivers/pdf/source

[julun]

Hi Michael,

Michael Pfeiffer schrieb:
> Am 21.10.2008 um 12:54 schrieb julun:
> 
>> Michael Pfeiffer schrieb:
>>> Am 21.10.2008 um 08:58 schrieb julun at BerliOS:
>>>
>>>> +#ifdef __HAIKU__
>>>> 	menu->ResizeToPreferred();
>>>> -	menu->SetDivider(0);
>>>> 	menu->MoveBy(frame.Width() + 10.0, 0.0);
>>>> +#else
>>>> +	menu->ResizeTo(menu->StringWidth("Default Keys") + 15.0, 25.0);
>>>> +	menu->MoveBy(menu->Bounds().Width() + 10.0, 0.0);
>>>> +#endif
>>> Does this mean the version built on BeOS wont work in Haiku anymore?
>>> If that's the case (= Haiku is not compatible to BeOS!) then this fix
>>> is not acceptable.
>> well that means that BMenuField is totally broken on BeOS, and we
>> decided to keep the better behavior (correct) for Haiku.
>>
>> If you don't like the solution, just go ahead and remove the
>> Haiku ifdef part and we stick with the hardcoded size until R1.
>> Maybe you wan't to use the current font to somehow fiddle the

should have been 'should use'

>> proper hight and set it.
> 
> Thanks for the clarification. I will then remove the __HAIKU__ stuff,  
> when I have time. That might include never too :)

Just short, R5 is broken i that regard as setting an initial size 
on a BMenuField and calling ResizeToPreferred does basically 
nothing or not what one would expect it to do. I noticed that 
while helping out on ArtPaint. The 'layout' code there was 
depending on that behavior too. I talked to Stephan about it and 
he made really the best out of both versions (Haiku/BeOS) for Haiku.

I probably need to check libprintutils, i might have introduced a 
dependency on layout code that will prevent a printer driver 
build on Haiku from working on BeOS.  :(

Karsten