[Haiku-commits] r24532 - in haiku/trunk: headers/private/print src/add-ons/print/shared

Marcus Overhagen marcusoverhagen at arcor.de
Mon Mar 24 12:58:32 CET 2008


julun at BerliOS schrieb:

> * some small cleanup
> * fFirstPage should be of type off_t

>  	int32 fNumberOfPages; // the number of pages in the job file
> -	int32 fFirstPage; // the page number of the first page
> +	off_t fFirstPage; // the page number of the first page

This change doesn't make any sense at all.

An int32 can already cover 2147483647 pages, that
are 4294967 packages with each 500 sheets.

And the implementation of the further functions won't work
with larger numbers anyway.

 >>	int32 FirstPage() const { return fFirstPage; }
 >>	int32 LastPage() const { return fFirstPage + fNumberOfPages - 1;


regards
Marcus



More information about the Haiku-commits mailing list