[Haiku-bugs] [Haiku] #1701: [BColorControl] Various selector bugs

[Haiku]

#1701: [BColorControl] Various selector bugs
---------------------------------+------------------------------------------
  Reporter:  aldeck              |       Owner:  jackburton    
      Type:  bug                 |      Status:  assigned      
  Priority:  normal              |   Milestone:  R1            
 Component:  Kits/Interface Kit  |     Version:  R1 development
Resolution:                      |    Platform:  All           
---------------------------------+------------------------------------------
Changes (by jackburton):

  * status:  new => assigned

Comment:

 I had a look at the patch. In theory it looks good, I think I'll apply in
 the next days.
 Only a few remarks:
 - You call Window() in _InitData(), where Window() is still NULL (it's
 valid only after AttachedToWindow()
 - I've moved setting fPaletteFrame to _LayoutView(), and called this last
 method inside SetCellSize(), so that it's resized dynamically.
 - I've disabled palette mode for now, since the colorspace should be
 recalculated if the workspace changes colorspace, or the window to which
 the view belongs is moved to a new workspace with different colorspace
 (overriding WorkspaceChanged() and ScreenChanged(), probably)

 Apart from this, you did a damn good work!

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/1701#comment:5>
Haiku <http://dev.haiku-os.org>
The Haiku operating system.