[Haiku-bugs] [Haiku] #1010: Screen Preferences: screen flickers a lot when "keeping" changes made to "All workspaces"

[Haiku]

#1010: Screen Preferences: screen flickers a lot when "keeping" changes made to
"All workspaces"
---------------------------------+------------------------------------------
  Reporter:  jonas.kirilla       |       Owner:  axeld         
      Type:  bug                 |      Status:  new           
  Priority:  normal              |   Milestone:  R1            
 Component:  Servers/app_server  |     Version:  R1 development
Resolution:                      |    Platform:  All           
---------------------------------+------------------------------------------
Changes (by wkornewald):

 * cc: wkornewald (added)
  * component:  - Preferences/Screen => Servers/app_server

Comment:

 I had a quick shot and it looks like an app_server bug. In `ServerApp.cpp`
 the code for `AS_SCREEN_SET_MODE` doesn't use the workspace argument, at
 all. I think that with each call to `BScreen::SetMode()` the resolution is
 changed for all workspaces instead of only the given one.

 The preflet could set the screen mode for all workspaces with one single
 call (instead of iterating over all workspaces), but then the app_server
 would have to make sure that the current workspace is only updated if the
 mode changed. Otherwise, only the other workspaces should be updated.

 I also noticed that `BScreen::SetMode(mode, makeDefault)` sets the mode
 for all workspaces. In R5 it seems to change the mode for the active
 workspace, only. The Screen preflet assumes R5 behavior, BTW. I'll fix
 that one if nobody objects.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/1010#comment:1>
Haiku <http://dev.haiku-os.org>
The Haiku operating system.